Assets Call Runtime #963
Closed
Assets Call Runtime #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be a breaking change in Shibuya, even though it's a testnet, I'm not sure we should just remove it. |
Dinonard
reviewed
Jul 27, 2023
Comment on lines
+775
to
+820
| pub struct CallRuntimeFilter; | ||
| impl Contains<RuntimeCall> for CallRuntimeFilter { | ||
| fn contains(c: &RuntimeCall) -> bool { | ||
| match *c { | ||
| RuntimeCall::Assets(pallet_assets::Call::transfer { .. }) => true, | ||
| RuntimeCall::Assets(pallet_assets::Call::transfer_approved { .. }) => true, | ||
| _ => false, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Wouldn't you also need approve in this case?
* Add value param to 'XvmCall'. * Fix precompile tests. * Update types in CE & precompiles. * Add EVM call tests for XVM. * New type idiom for EthereumTxInput. * Add XVM integration tests. * More XVM integration tests. * Fix runtime tests. * Move contract deploy helpers to setup.rs. * Update value adjustment for wasm payable calls. * More pallet-xvm unit tests. * Update pallet-xvm weight info. * Apply review suggestions. * Fix runtime tests. * Calling WASM payable from EVM fails if caller contract balance below ED. * Update weight info. * Fix unit tests.
* pallet-xvm max weight limit config. * Fix runtime tests. * Forbid XVM re-entrancy. * XVM Re-entrance tests. * Naming consistency. * XVM precompile: respect caller's gas limit setting. * Remove max weight limit config from pallet-xvm. * Remove unused XVM call error. * Add tests for XVM precompile gas limit.
* feat: add batch precompile * typo * add tests * minor fixes and updates * refactor, add batch to local * fix expect_arguments * add logs * update license * taplo fix * more refactor, remote evm crate * remove evm crate, update utils version, add std in dappsstaking * update pallet_balances::config in mock * update pallet_evm config * update license * add to std-feature * utils: rectify patch to minor update * remove pub from logs function * fix typos * remove comments * refactor * fmt
* Automatic EVM revert code registration for XC20 * Add negative test * Fmt fix * Add EVM module * Asset benchmarks * Cleanup xc asset config * Update asset benchmarks * Fix tests features
PierreOssun
force-pushed
the
feature/assets-call-runtime
branch
from
edcc9c2
to
ff3011c
Compare
Minimum allowed line rate is |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR removes chain extensions from the runtime.
Add assets_pallet transfer & transfer_approved in call filter to allow call_runtime in ink! contracts.
Note: call_runtime host function has been stabilized recently #13901 but we need to allow unstable interface in the meantime.
Check list