Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: adds version command to chasten #73

Merged
merged 22 commits into from
Oct 13, 2023
Merged

Feature: adds version command to chasten #73

merged 22 commits into from
Oct 13, 2023

Conversation

CalebKendra
Copy link
Collaborator

This adds a command to be able to check the version of chasten via PyPi. chasten version runs:

chasten 0.1.1

@CalebKendra CalebKendra added the enhancement New feature or request label Sep 25, 2023
@CalebKendra CalebKendra linked an issue Sep 25, 2023 that may be closed by this pull request
Provide a Sub-Command for the Output of Version Information #12
Closed
@CalebKendra
Copy link
Collaborator Author

CalebKendra commented Sep 25, 2023 •
edited
Loading

Give credit to @Jaclynpqc, as she did most of the work for this feature

@CalebKendra CalebKendra added the ready-for-review This pull request is ready for review label Sep 25, 2023
@CalebKendra CalebKendra removed the ready-for-review This pull request is ready for review label Sep 25, 2023
Jaclynpqc
Jaclynpqc reviewed Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@Jaclynpqc Jaclynpqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Caleb for fixing the error. I see you added some visual changes to the code, I like it. Thank you for the improvement

@Jaclynpqc Jaclynpqc added the in-progress Work is actively happening on this issue label Sep 25, 2023
@laurennevill
Copy link
Collaborator

It looks like this PR does not have a passing build. Please look into this and I will be happy to review once the build is passing. Thanks!

@Jaclynpqc
Copy link
Collaborator

@laurennevill Yes, I'm working on resolving the Linter issues

@Jaclynpqc Jaclynpqc changed the title Feature: adds version command to chasten WIP: Feature: adds version command to chasten Sep 26, 2023
@Jaclynpqc Jaclynpqc added the ready-for-review This pull request is ready for review label Sep 28, 2023
@Jaclynpqc Jaclynpqc changed the title WIP: Feature: adds version command to chasten Feature: adds version command to chasten Sep 28, 2023
@Jaclynpqc Jaclynpqc removed the ready-for-review This pull request is ready for review label Sep 29, 2023
@Jaclynpqc Jaclynpqc changed the title Feature: adds version command to chasten WIP:Feature: adds version command to chasten Sep 29, 2023
@Jaclynpqc
Copy link
Collaborator

Hey @CalebKendra, have you done git pull from master branch?

@CalebKendra CalebKendra added ready-for-review This pull request is ready for review and removed in-progress Work is actively happening on this issue labels Oct 4, 2023
@CalebKendra CalebKendra changed the title WIP:Feature: adds version command to chasten Feature: adds version command to chasten Oct 4, 2023
laurennevill
laurennevill approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@laurennevill laurennevill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Great work everyone!

@hayleepierce hayleepierce self-requested a review October 6, 2023 13:47
jnormile
jnormile approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@jnormile jnormile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix to a straightforward problem. Thanks for implementing!

@laurennevill laurennevill merged commit e102e45 into master Oct 13, 2023
3 checks passed
@laurennevill laurennevill deleted the chastenversion branch October 13, 2023 17:36
@Jaclynpqc Jaclynpqc restored the chastenversion branch October 15, 2023 23:22
@Jaclynpqc
Copy link
Collaborator

After merging, the merge of PR#73 broke the build. I'm working on troubleshooting the problem.
Update: I updated the branch to be up-to-date with the master branch and rerun the checks. So far, all checks passed on my local machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaclynpqc Jaclynpqc Jaclynpqc left review comments

@laurennevill laurennevill laurennevill approved these changes

@jnormile jnormile jnormile approved these changes

@hayleepierce hayleepierce hayleepierce approved these changes

@gkapfham gkapfham Awaiting requested review from gkapfham

@AidanNeeson AidanNeeson Awaiting requested review from AidanNeeson

@bergasanargya bergasanargya Awaiting requested review from bergasanargya

Assignees

@Jaclynpqc Jaclynpqc

@CalebKendra CalebKendra

Labels
enhancement New feature or request ready-for-review This pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a Sub-Command for the Output of Version Information
5 participants
@CalebKendra @laurennevill @Jaclynpqc @jnormile @hayleepierce