[DLFL23] 14-truck_backer_upper.ipynb - Fix oudated matplotlib API usage #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dqian3
changed the title
|
Just a heads up, you can review notebook changes like this using GitNotebooks. e.g. this pull request https://gitnotebooks.com/Atcold/NYU-DLSP20/pull/846 It allows inline comments on code and markdown, and it's free for public repos so I thought I'd share.. |
|
@smith-kyle, how is it any different from ReviewNB? |
|
@Atcold Pretty similar but it's a bit more performant, supports multi-line comments, and code comments appear inline like GitHub |
|
@smith-kyle, I'm not sure why you're telling me this on this PR, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to get the truck backer upper working as shown in the NYU Deep Learning class, but rather than downgrade jupyter and matplotlib, I figured out what needed to be changed to make the the notebook work with the latest version.
Tested with a fresh conda install, but haven't tried the other notebooks.
Summary of changes:
matplotlib.patches.Rectanglepylabimports with pythonrandomandmathmodules.truck_backer-upper=>truck_backer_upper%matplotlib notebook