-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C-5129, C-5130] Add reply/mention push/email notifications #9998
base: main
Are you sure you want to change the base?
Conversation
|
Preview this change https://demo.audius.co/c-5129-reply-notifications |
) | ||
} | ||
|
||
// If the user has devices to the notification to, proceed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// If the user has devices to the notification to, proceed | |
// If the user has devices to send the notification to, proceed |
) | ||
} | ||
|
||
// If the user has devices to the notification to, proceed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// If the user has devices to the notification to, proceed | |
// If the user has devices to send the notification to, proceed |
comment_id: mention.comment_id, | ||
user_id: mention.user_id, | ||
created_at: new Date(Date.now()), | ||
updated_at: new Date(Date.now()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious - do we generally follow this pattern (set updated_at during creation), or do we leave it null until an update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is set to created on initialization is what i gather from other models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crazy how much is required
Updates notification plugin to add mobile push and browser notifications. Also adds 'mentions' to identity-service records, and updates ui