Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-5129, C-5130] Add reply/mention push/email notifications #9998

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dylanjeffers
Copy link
Contributor

@dylanjeffers dylanjeffers commented Oct 9, 2024

Updates notification plugin to add mobile push and browser notifications. Also adds 'mentions' to identity-service records, and updates ui

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: dfbe492

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/c-5129-reply-notifications

)
}

// If the user has devices to the notification to, proceed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// If the user has devices to the notification to, proceed
// If the user has devices to send the notification to, proceed

)
}

// If the user has devices to the notification to, proceed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// If the user has devices to the notification to, proceed
// If the user has devices to send the notification to, proceed

comment_id: mention.comment_id,
user_id: mention.user_id,
created_at: new Date(Date.now()),
updated_at: new Date(Date.now()),
Copy link
Contributor

@DejayJD DejayJD Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious - do we generally follow this pattern (set updated_at during creation), or do we leave it null until an update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is set to created on initialization is what i gather from other models

Copy link
Contributor

@DejayJD DejayJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Contributor

@isaacsolo isaacsolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy how much is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants