add context menu support #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #731 +/- ##
==========================================
+ Coverage 18.34% 18.37% +0.03%
==========================================
Files 17 17
Lines 1532 1540 +8
Branches 335 337 +2
==========================================
+ Hits 281 283 +2
- Misses 1219 1223 +4
- Partials 32 34 +2
Continue to review full report at Codecov.
|
mymindstorm
requested changes
Sep 4, 2021
manifests/manifest-firefox.json
Outdated
| @@ -47,6 +47,7 @@ | |||
| "optional_permissions": [ | |||
| "<all_urls>", | |||
| "clipboardWrite", | |||
| "contextMenus", | |||
There was a problem hiding this comment.
This is not an allowed optional permission in Firefox. I think it may be best to just remove Firefox support for this feature rather than adding a required permission.
| onclick: (_, tab) => { | ||
| let popupUrl = "view/popup.html?popup=true"; | ||
| if (tab.url && tab.title) { | ||
| popupUrl += |
There was a problem hiding this comment.
Inconsistent behavior with filtering on example.com:
src/store/Accounts.ts
Outdated
| return resolve([title, null]); | ||
| } | ||
|
|
||
| const urlParser = document.createElement("a"); | ||
| urlParser.href = tab.url; | ||
| urlParser.href = url; |
There was a problem hiding this comment.
We should convert this to URL.hostname rather than messing with the DOM.
mymindstorm
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.