cleanup: Remove setProxyTarget function (ethereum-optimism#2516)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Auto00000 · May 1, 2022 · cc0594c · cc0594c
1 parent 8c9ac5f
commit cc0594c
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 36 deletions.
diff --git a/packages/contracts/test/contracts/L1/messaging/L1CrossDomainMessenger.spec.ts b/packages/contracts/test/contracts/L1/messaging/L1CrossDomainMessenger.spec.ts
@@ -6,7 +6,6 @@ import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/signers'
 
 import { expect } from '../../../setup'
 import {
-  setProxyTarget,
   NON_NULL_BYTES32,
   NON_ZERO_ADDRESS,
   DUMMY_BATCH_HEADERS,
@@ -57,10 +56,9 @@ describe('L1CrossDomainMessenger', () => {
       Fake__L2CrossDomainMessenger.address
     )
 
-    await setProxyTarget(
-      AddressManager,
+    await AddressManager.setAddress(
       'StateCommitmentChain',
-      Fake__StateCommitmentChain
+      Fake__StateCommitmentChain.address
     )
 
     CanonicalTransactionChain = await deploy('CanonicalTransactionChain', {

diff --git a/packages/contracts/test/contracts/L1/rollup/CanonicalTransactionChain.gas.spec.ts b/packages/contracts/test/contracts/L1/rollup/CanonicalTransactionChain.gas.spec.ts
@@ -13,7 +13,6 @@ import { TransactionResponse } from '@ethersproject/abstract-provider'
 /* Internal Imports */
 import {
   deploy,
-  setProxyTarget,
   L2_GAS_DISCOUNT_DIVISOR,
   ENQUEUE_GAS_COST,
   getEthTime,
@@ -59,10 +58,9 @@ describe('[GAS BENCHMARK] CanonicalTransactionChain [ @skip-on-coverage ]', () =
       'StateCommitmentChain'
     )
 
-    await setProxyTarget(
-      AddressManager,
+    await AddressManager.setAddress(
       'StateCommitmentChain',
-      Fake__StateCommitmentChain
+      Fake__StateCommitmentChain.address
     )
 
     CanonicalTransactionChain = await deploy('CanonicalTransactionChain', {

diff --git a/packages/contracts/test/contracts/L1/rollup/CanonicalTransactionChain.spec.ts b/packages/contracts/test/contracts/L1/rollup/CanonicalTransactionChain.spec.ts
@@ -12,7 +12,6 @@ import _ from 'lodash'
 import { expect } from '../../../setup'
 import {
   deploy,
-  setProxyTarget,
   L2_GAS_DISCOUNT_DIVISOR,
   ENQUEUE_GAS_COST,
   setEthTime,
@@ -67,10 +66,9 @@ describe('CanonicalTransactionChain', () => {
       'StateCommitmentChain'
     )
 
-    await setProxyTarget(
-      AddressManager,
+    await AddressManager.setAddress(
       'StateCommitmentChain',
-      Fake__StateCommitmentChain
+      Fake__StateCommitmentChain.address
     )
 
     CanonicalTransactionChain = await deploy('CanonicalTransactionChain', {

diff --git a/packages/contracts/test/contracts/L1/rollup/StateCommitmentChain.spec.ts b/packages/contracts/test/contracts/L1/rollup/StateCommitmentChain.spec.ts
@@ -6,7 +6,6 @@ import { smock, FakeContract } from '@defi-wonderland/smock'
 import { expect } from '../../../setup'
 import {
   deploy,
-  setProxyTarget,
   NON_NULL_BYTES32,
   getEthTime,
   increaseEthTime,
@@ -30,15 +29,14 @@ describe('StateCommitmentChain', () => {
       'CanonicalTransactionChain'
     )
 
-    await setProxyTarget(
-      AddressManager,
+    await AddressManager.setAddress(
       'CanonicalTransactionChain',
-      Fake__CanonicalTransactionChain
+      Fake__CanonicalTransactionChain.address
     )
 
     Fake__BondManager = await smock.fake<Contract>('BondManager')
 
-    await setProxyTarget(AddressManager, 'BondManager', Fake__BondManager)
+    await AddressManager.setAddress('BondManager', Fake__BondManager.address)
 
     Fake__BondManager.isCollateralized.returns(true)
 

diff --git a/packages/contracts/test/helpers/index.ts b/packages/contracts/test/helpers/index.ts
@@ -1,6 +1,5 @@
 export * from './dummy'
 export * from './constants'
-export * from './resolver'
 export * from './utils'
 export * from './codec'
 export * from './test-runner'

diff --git a/packages/contracts/test/helpers/resolver/address-manager.ts b/packages/contracts/test/helpers/resolver/address-manager.ts
diff --git a/packages/contracts/test/helpers/resolver/index.ts b/packages/contracts/test/helpers/resolver/index.ts