feat(schema): allow using set as a schema path

Fix #1939
Automattic · Oct 30, 2017 · 01bf209 · 01bf209
1 parent 2068a4b
commit 01bf209
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/schema.js b/lib/schema.js
@@ -443,7 +443,6 @@ reserved.get =
 reserved.modelName =
 reserved.save =
 reserved.schema =
-reserved.set =
 reserved.toObject =
 reserved.validate =
 reserved.remove =

diff --git a/test/document.test.js b/test/document.test.js
@@ -4750,6 +4750,24 @@ describe('document', function() {
       });
     });
 
+    it('Using set as a schema path (gh-1939)', function(done) {
+      var testSchema = new Schema({ set: String });
+
+      var Test = db.model('gh1939', testSchema);
+
+      var t = new Test({ set: 'test 1' });
+      assert.equal(t.set, 'test 1');
+      t.save(function(error) {
+        assert.ifError(error);
+        t.set = 'test 2';
+        t.save(function(error) {
+          assert.ifError(error);
+          assert.equal(t.set, 'test 2');
+          done();
+        });
+      });
+    });
+
     it('Single nested subdocs using discriminator can be modified (gh-5693)', function(done) {
       var eventSchema = new Schema({ message: String }, {
         discriminatorKey: 'kind',