Added unit test for setting default values with timestamps.

Automattic · Jan 22, 2018 · 0ff2f94 · 0ff2f94
1 parent bff15e3
commit 0ff2f94
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 17 deletions.
diff --git a/lib/schema.js b/lib/schema.js
@@ -804,22 +804,17 @@ Schema.prototype.hasMixedParent = function(path) {
  */
 Schema.prototype.setupTimestamp = function(timestamps) {
   if (timestamps) {
-    var paths = ['createdAt', 'updatedAt'].map(handleTimestampOption.bind(null, timestamps));
-    var createdAt = paths[0];
-    var updatedAt = paths[1];
-    var schemaAdditions = paths.reduce(function(cur, path) {
-      if (path != null) {
-        var parts = path.split('.');
-        if (this.pathType(path) === 'adhocOrUndefined') {
-          for (var i = 0; i < parts.length; ++i) {
-            cur[parts[i]] = (i < parts.length - 1 ?
-            cur[parts[i]] || {} :
-              Date);
-          }
-        }
-      }
-      return cur;
-    }.bind(this), {});
+    var createdAt = handleTimestampOption(timestamps, 'createdAt');
+    var updatedAt = handleTimestampOption(timestamps, 'updatedAt');
+    var schemaAdditions = {};
+
+    if (updatedAt && !this.paths[updatedAt]) {
+      schemaAdditions[updatedAt] = Date;
+    }
+
+    if (createdAt && !this.paths[createdAt]) {
+      schemaAdditions[createdAt] = Date;
+    }
 
     this.add(schemaAdditions);
 

diff --git a/test/document.test.js b/test/document.test.js
@@ -3801,7 +3801,7 @@ describe('document', function() {
     });
 
     it('timestamps with nested paths (gh-5051)', function(done) {
-      var schema = new Schema({ props: Object }, {
+      var schema = new Schema({ props: {} }, {
         timestamps: {
           createdAt: 'props.createdAt',
           updatedAt: 'props.updatedAt'