fix(populate): dedupe model names with embedded discriminators

Re: #5983
Automattic · Jan 26, 2018 · b510cb9 · b510cb9
1 parent b4b59c4
commit b510cb9
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/model.js b/lib/model.js
@@ -3573,7 +3573,12 @@ function getModelsMapForPopulate(model, docs, options) {
         if (!_modelNames) {
           continue;
         }
-        modelNames = (modelNames || []).concat(_modelNames);
+        modelNames = (modelNames || []);
+        for (var k = 0; k < _modelNames.length; ++k) {
+          if (modelNames.indexOf(_modelNames[k]) === -1) {
+            modelNames.push(_modelNames[k]);
+          }
+        }
       }
     } else {
       modelNames = _getModelNames(doc, schema);
@@ -3674,6 +3679,7 @@ function getModelsMapForPopulate(model, docs, options) {
 
   function _getModelNames(doc, schema) {
     var modelNames;
+    var discriminatorKey;
 
     if (schema && schema.caster) {
       schema = schema.caster;