Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy 4.x links point to new docs #6081

Closed
lineus opened this issue Feb 2, 2018 · 2 comments
Closed

Legacy 4.x links point to new docs #6081

lineus opened this issue Feb 2, 2018 · 2 comments
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Milestone

Comments

@lineus
Copy link
Collaborator

lineus commented Feb 2, 2018

when using the legacy docs for 4.x, clicking a link in the guide should probably resolve to another 4.x doc instead of the current ones. Multiple pages in the 4.x docs have links with absolute paths to the current docs, ie. Clicking on the middleware link on the [4.x subdocs] (http://mongoosejs.com/docs/4.x/docs/subdocs.html) guide for instance, will take you to the current docs. I was going to update them and create a pull request but when I checked out the master branch I didn't see a 4.x folder under docs/ . Are the 4.x docs derived from the 4.x branch ? Just a subtle nudge in the general direction and I'll get it done :)
edit: I found the relevant info in the makefile for how the 4.x legacy docs get created.
is this a worthwhile endeavor?

@sobafuchs
Copy link
Contributor

not sure, thoughts @vkarpov15 ?

@sobafuchs sobafuchs added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Feb 6, 2018
@sobafuchs sobafuchs added this to the 5.0.4 milestone Feb 6, 2018
vkarpov15 added a commit that referenced this issue Feb 7, 2018
@vkarpov15 vkarpov15 modified the milestones: 5.0.4, 4.13.11 Feb 7, 2018
@vkarpov15
Copy link
Collaborator

Thanks for pointing this out, I think I fixed most of them in 3660092, will deploy those changes with 4.13.11. Feel free to use those changes as an example if you find any others, and make a PR against the 4.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

No branches or pull requests

3 participants