Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine query selector to highlight unexpected query keys #14764

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Refine query selector to highlight unexpected query keys #14764

merged 7 commits into from
Aug 12, 2024

Commits on Jul 26, 2024

  1. Refine query selector to highlight unexpected query keys 

    Previously, there was a catch-all case in RootQuerySelector which would accept any key with type "any". This still allows nice IDE typehints, but can lead to bugs where the incorrect key is used for a filter with no warning that the key is clearly wrong.

With this PR, only keys that contain a "." are unsafely typed as any, which should reduce the blast radius of the hacky types dramatically.
    @alex-statsig
    alex-statsig authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    330dd36 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Add separate RootFilterQuery to type some cases better, add test cases

    @alex-statsig
    alex-statsig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    ea2a4ef View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Fix new typescript error assertions

    @alex-statsig
    alex-statsig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b810a9d View commit details
    Browse the repository at this point in the history

  2. Fix one more ts-expect-error to use expectError

    @alex-statsig
    alex-statsig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    baf3ca2 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Merge branch '8.6' into patch-1

    @vkarpov15
    vkarpov15 authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    50b26dc View commit details
    Browse the repository at this point in the history

  2. Update models.d.ts

    @vkarpov15
    vkarpov15 authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    8d6422b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Fix queryhelpers test

    @alex-statsig
    alex-statsig committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e5c9b7b View commit details
    Browse the repository at this point in the history