feat: useConnection(connection) function
#14802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Aug 20, 2024
test/model.test.js
Outdated
| name: String | ||
| }); | ||
| const Model = db.model('Test', schema); | ||
| const connection = start(); |
There was a problem hiding this comment.
We should expand this test to use a different uri than db, and assert that Model.find() executes queries against the new uri rather than the old uri.
As written, I don't think that will work because on further review we'll need to also update the model's collection properties (see Model.compile())
const collection = connection.collection(
collectionName,
collectionOptions
);
model.prototype.collection = collection;
model.prototype.$collection = collection;
model.prototype[modelCollectionSymbol] = collection;
| delete this.db.models[this.modelName]; | ||
| } | ||
| this.db = connection; | ||
| connection.models[this.modelName] = this; |
There was a problem hiding this comment.
We'll need to test this a bit more thoroughly, it looks like we also need to modify the model's collection as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.