Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): throw error if bulkSave() did not insert or update any documents #14837

Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix(model): throw error if bulkSave() did not insert or update any documents #14837

merged 3 commits into from
Sep 3, 2024

Conversation

vkarpov15
Copy link
Collaborator

Re: #14763

Summary

First step for fixing #14763 (option 1), throwing an error if bulkSave() did not update or insert any documents successfully.

Examples

@vkarpov15 vkarpov15 added this to the 8.5.5 milestone Aug 28, 2024
@vkarpov15 vkarpov15 modified the milestones: 8.5.5, 8.6.1 Aug 28, 2024
AbdelrahmanHafez
AbdelrahmanHafez reviewed Aug 28, 2024
View reviewed changes
lib/model.js Outdated Show resolved Hide resolved
@vkarpov15 @AbdelrahmanHafez
Update lib/model.js
5b40f1b 
Co-authored-by: Hafez <a.hafez852@gmail.com>
@vkarpov15 vkarpov15 merged commit c37e345 into master Sep 3, 2024
46 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14763 branch September 3, 2024 20:31
@nejidevelops nejidevelops mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 25, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 25, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 25, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 25, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 25, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Sep 25, 2024
Open
@ASMAAGOMA ASMAAGOMA mentioned this pull request Sep 25, 2024
Open
@dineshade00 dineshade00 mentioned this pull request Sep 25, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 25, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Oct 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 3, 2024
Open
@kush2124 kush2124 mentioned this pull request Oct 3, 2024
Open
@riyoneri riyoneri mentioned this pull request Oct 3, 2024
Merged
@carltrepanier carltrepanier mentioned this pull request Oct 3, 2024
Merged
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Oct 3, 2024
Open
@aditya-arcot aditya-arcot mentioned this pull request Oct 3, 2024
Merged
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Oct 3, 2024
Open
@Nate2898 Nate2898 mentioned this pull request Oct 3, 2024
Open
@Bowist27 Bowist27 mentioned this pull request Oct 3, 2024
Open
@solitariusdigital solitariusdigital mentioned this pull request Oct 3, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
Open
@tuanicom tuanicom mentioned this pull request Oct 3, 2024
Merged
@MihikaNigam MihikaNigam mentioned this pull request Oct 3, 2024
Open
@caverav caverav mentioned this pull request Oct 3, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Oct 3, 2024
Open
@silentsysop silentsysop mentioned this pull request Oct 3, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 4, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Oct 4, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 5, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 5, 2024
Open
@MoaidHashem3 MoaidHashem3 mentioned this pull request Oct 5, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Oct 5, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 6, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Oct 6, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Oct 6, 2024
Open
@ASHOKECE1999 ASHOKECE1999 mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez