fix: set flattenObjectIds to false when calling toObject() for internal purposes #14938
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hasezoey
approved these changes
Oct 9, 2024
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14935
Summary
insertMany()currently respects schema-level flattenObjectIds option settings, which means if schema setsflattenObjectIds: truethen Mongoose will store ObjectIds as strings.This does not affect
save()becausesave()was fixed in #13648, but that issue still affectsinsertMany().In general,
internalToObjectOptionsshould always setflattenObjectIdstotruebecause we rely on those options when trying to get the MongoDB server representation of an object for queries,insertMany(), etc.We should also backport this fix to 6.x and 7.x.
Examples