4.x ci improve #6853
Merged
4.x ci improve #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fonger
force-pushed
the
4.x-ci-improve
branch
3 times, most recently
from
f689832
to
06b64df
Compare
Fonger
commented
Aug 14, 2018
| assert.ifError(error); | ||
| done(); | ||
| }); | ||
| MyModel.on('index', function(err) { |
There was a problem hiding this comment.
should have used init() here but this is cherry-pick from master branch
There're many other test cases using on('index') so this should be done in a future fix in master
There was a problem hiding this comment.
Yeah that's fair, we'll do that later. For now, I don't want to put more effort into 4.x than is necessary. We'll make the changes in master when it is convenient.
vkarpov15
approved these changes
Aug 14, 2018
| assert.ifError(error); | ||
| done(); | ||
| }); | ||
| MyModel.on('index', function(err) { |
There was a problem hiding this comment.
Yeah that's fair, we'll do that later. For now, I don't want to put more effort into 4.x than is necessary. We'll make the changes in master when it is convenient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cherry-pick some fix of flaky tests from
masterwhile maintaining compatibility with legacyNode.js 0.10also manually fix 2 additional flaky tests specific to
4.x