Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: make types compatible with typescript 4.6 #1986

Merged
merged 1 commit into from
Feb 24, 2022
Merged

CI fix: make types compatible with typescript 4.6 #1986

merged 1 commit into from
Feb 24, 2022

Conversation

chearon
Copy link
Collaborator

@chearon chearon commented Feb 10, 2022

Typescript 4.6 seems to have changed globalCompositeOperation from string to an enum of strings, which means instead of narrowing the type we are now trying to widen it, which is impossible.

Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

@LinusU LinusU merged commit 6fd0fa5 into master Feb 24, 2022
@LinusU LinusU deleted the fix-ci branch February 24, 2022 19:12
@chearon chearon mentioned this pull request Mar 1, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants