Update proposals advanced search #2133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
reviewed
May 10, 2021
The 0.3.5 version was yanked due to license issues. More information at: rails/rails#41750
Senen
force-pushed
the
proposals_filters
branch
2 times, most recently
from
b2ddc0e
to
cd5b265
Compare
javierm
reviewed
May 20, 2021
Remove unused code
* Add combo box with geozones to advanced search * Add scope to custom proposal model to filter records by geozone
These specs check that the advanced search form works when using multiple filters at a time. Now we removed the author category filter we can use the new filter by geozone to check the same.
As we are going to modify how and where the geozone links are rendered.
As we want the proposals geozones links to point to the new combo box within the advanced search. We needed to remove the id attribute from the new custom geozone view as we now render it at the same page many times. Otherwise the generated HTML would be invalid. No additional test are needed as the new feature behaves exactly the same than the previous version but using the geozone filter instead of the search by text.
Now we want the geozone links and the map image areas to point to the proposals advanced search filter by geozone. No additional test are needed as the feature keep working the same it was with the previous version but using the advanced search form filter by geozone instead of the search by plain text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is part of the Ciudades Abiertas project.
Objectives
Improve proposals search:
Visual Changes
Before
Advanced search filter with filter by author category
How the proposal was shown before this change
After
Advanced search filter
Show proposals district as a tag
Does this PR need a Backport to CONSUL?
No