Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary config lines #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1248,9 +1248,6 @@ metadata:
namespace: ${namespace}
annotations:
azure.workload.identity/client-id: ${appId}
azure.workload.identity/tenant-id: ${tenantId}
labels:
azure.workload.identity/use: "true"
EOF
else
azwi serviceaccount create phase sa \
Expand Down
8 changes: 0 additions & 8 deletions chart/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,6 @@ Create the name of the service account to use
{{- end }}
{{- end }}

{{/*
Create service account labels
*/}}
{{- define "todolist.serviceAccount.labels" -}}
azure.workload.identity/use: "true"
{{- end }}

{{/*
Frontend service and deployment labels
*/}}
Expand Down Expand Up @@ -154,5 +147,4 @@ Service account annotations
{{ end }}
{{- end -}}
azure.workload.identity/client-id: {{ .Values.serviceAccount.appId }}
azure.workload.identity/tenant-id: {{ .Values.serviceAccount.tenantId }}
{{- end }}
3 changes: 1 addition & 2 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ serviceAccount:
# If not set and create is true, a name is generated using the fullname template
name: "todolist-identity-sa"
appId: ""
tenantId: ""

configMap:
aspNetCoreEnvironment: Docker
Expand Down Expand Up @@ -207,4 +206,4 @@ backendIngress:
- host: oxapi.babosbird.com
tls:
- hosts:
- oxapi.babosbird.com
- oxapi.babosbird.com