Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable guest configuration package versioning and include situation when server is a Domain Controller #441

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

jyeblog
Copy link

@jyeblog jyeblog commented Sep 9, 2021

  1. According to https://docs.microsoft.com/en-us/azure/governance/policy/how-to/guest-configuration-create-definition#policy-lifecycle, it's recommended to include a version number in the package name, as well as update Version and contentUri when using New-GuestConfigurationPolicy. The original code hardcoded to use version 1.0.0, so consquent package updates were ignored. I have included versioning in the new code.
  2. Previous code using (Get-CimInstance -ClassName Win32_OperatingSystem).ProductType to deteremine if OS is Desktop or Server, but the condition only includes 1 (Desktop) or 3 (Server), it was missing 2 (Domain Controller), which is really also a server product. This cause the script to fail on a domain controller.

Both issues were logged in ticket: 2104130010004629

@TomJanetscheck TomJanetscheck merged commit 23a7bec into Azure:main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants