Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move zipkin to tech-usage #178

Merged
merged 1 commit into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</or>
</when>
<perform>
<hint title="Embedded framework - Feign" category-id="information" effort="0">
<hint title="Embedded framework - Feign" category-id="information" effort="0">
<message>
The application embeds the Feign framework. If you are migrating to Azure Spring Apps, it is recommended to use Spring Cloud OpenFeign instead (Spring Cloud Feign has been deprecated).

Expand All @@ -44,6 +44,35 @@
<technology-tag level="INFORMATIONAL">Feign</technology-tag>
</perform>
</rule>
<rule id="embedded-framework-09100">
<when>
<or>
<file filename="{*}zipkin{*}.jar"/>
<project>
<artifact groupId="org.springframework.boot" artifactId="spring-cloud-starter-zipkin"/>
</project>
<project>
<artifact groupId="io.zipkin{*}" artifactId="{*}"/>
</project>
</or>
</when>
<perform>
<hint title="Embedded framework - Zipkin" category-id="information" effort="0">
<message>
The application embeds the Zipkin framework. To migrate a Java application that uses Zipkin to Azure, it is recommended to use Azure Monitor instead.

* **Identify Zipkin dependencies**: Identify the Zipkin dependencies in your application.

* **Replace with Azure Monitor**: Azure Monitor provides distributed tracing capabilities. Azure services such as Azure Spring Apps, Azure Kubernetes Service, Azure App Service support auto-instrumentation for Azure Monitor.
</message>
<link title="Azure Monitor" href="https://learn.microsoft.com/azure/azure-monitor/"/>
<link title="Spring Boot to Azure - identify Zipkin dependencies" href="https://learn.microsoft.com/azure/developer/java/migration/migrate-spring-cloud-to-azure-spring-apps?pivots=sc-standard-tier#identify-zipkin-dependencies"/>
<link title="Use Application Insights Java In-Process Agent in Azure Spring Apps" href="https://learn.microsoft.com/azure/spring-apps/how-to-application-insights"/>
<link title="Distributed Tracing" href="https://learn.microsoft.com/azure/azure-monitor/app/distributed-trace-data"/>
</hint>
<technology-tag level="INFORMATIONAL">Zipkin</technology-tag>
</perform>
</rule>
<rule id="embedded-framework-09300">
<when>
<or>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@
<fail message="Feign found hint was not found!"/>
</perform>
</rule>
<rule id="embedded-framework-azure-appservice-test-09100">
<when>
<not>
<hint-exists message="The application embeds the Zipkin framework. To migrate a Java application that uses Zipkin to Azure"/>
</not>
</when>
<perform>
<fail message="Zipkin found hint was not found!"/>
</perform>
</rule>
<rule id="embedded-framework-azure-appservice-test-09300">
<when>
<not>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,17 @@
<fail message="Expected data not found for rule embedded-framework-09000"/>
</perform>
</rule>
<rule id="embedded-framework-09100-test">
<when>
<not>
<classification-exists classification="Embedded framework - Zipkin"/>
<technology-tag-exists technology-tag="Zipkin"/>
</not>
</when>
<perform>
<fail message="Expected data not found for rule embedded-framework-09100"/>
</perform>
</rule>
<rule id="embedded-framework-09300-test">
<when>
<not>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.