Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade component net.lingala.zip4j #260

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

joe-braley
Copy link
Collaborator

Enforce version 2.11.5 of zip4j using dependencyManagement.

Copy link
Collaborator

@kthatipally kthatipally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@karianna
Copy link
Contributor

Tests fail with:

Failed tests:
2024-10-16T05:12:50.7355396Z WindupRulesTest.testWindupRules:155
2024-10-16T05:12:50.7356386Z Error with test: configuration-management-technology-usage-0100-test
2024-10-16T05:12:50.7357669Z Cause: (Rule: configuration-management-technology-usage-0100-test) Assertion failed: Expected data not found for rule configuration-management-technology-usage-0100
2024-10-16T05:12:50.7358726Z
2024-10-16T05:12:50.7359099Z Error with test: configuration-management-0100-test
2024-10-16T05:12:50.7360314Z Cause: (Rule: configuration-management-0100-test) Assertion failed: Expected data not found for rule configuration-management-0100
2024-10-16T05:12:50.7360961Z
2024-10-16T05:12:50.7361199Z Error with test: technology-usage-database-01500-test
2024-10-16T05:12:50.7362110Z Cause: (Rule: technology-usage-database-01500-test) Assertion failed: Expected data not found for rule technology-usage-database-01500
2024-10-16T05:12:50.7362757Z
2024-10-16T05:12:50.7362976Z Error with test: technology-usage-database-01700-test
2024-10-16T05:12:50.7363871Z Cause: (Rule: technology-usage-database-01700-test) Assertion failed: Expected data not found for rule technology-usage-database-01700
2024-10-16T05:12:50.7364509Z
2024-10-16T05:12:50.7364727Z Error with test: technology-usage-database-01900-test
2024-10-16T05:12:50.7365638Z Cause: (Rule: technology-usage-database-01900-test) Assertion failed: Expected data not found for rule technology-usage-database-01900
2024-10-16T05:12:50.7366278Z
2024-10-16T05:12:50.7366499Z Error with test: technology-usage-database-02200-test
2024-10-16T05:12:50.7367696Z Cause: (Rule: technology-usage-database-02200-test) Assertion failed: Expected data not found for rule technology-usage-database-02200
2024-10-16T05:12:50.7368350Z
2024-10-16T05:12:50.7368567Z Error with test: technology-usage-database-02500-test
2024-10-16T05:12:50.7369458Z Cause: (Rule: technology-usage-database-02500-test) Assertion failed: Expected data not found for rule technology-usage-database-02500
2024-10-16T05:12:50.7370093Z
2024-10-16T05:12:50.7370308Z Error with test: technology-usage-database-03200-test
2024-10-16T05:12:50.7371207Z Cause: (Rule: technology-usage-database-03200-test) Assertion failed: Expected data not found for rule technology-usage-database-03200
2024-10-16T05:12:50.7371837Z
2024-10-16T05:12:50.7372056Z Error with test: technology-usage-connect-01500-test
2024-10-16T05:12:50.7372942Z Cause: (Rule: technology-usage-connect-01500-test) Assertion failed: Expected data not found for rule technology-usage-connect-01500
2024-10-16T05:12:50.7373569Z
2024-10-16T05:12:50.7373790Z Error with test: embedded-cache-libraries-test-01000
2024-10-16T05:12:50.7374633Z Cause: (Rule: embedded-cache-libraries-test-01000) Assertion failed: Technology usage - Ehcache classification not found!
2024-10-16T05:12:50.7375228Z
2024-10-16T05:12:50.7375232Z
2024-10-16T05:12:50.7375384Z Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

@joe-braley
Copy link
Collaborator Author

joe-braley commented Oct 16, 2024

@karianna I spoke with @kthatipally offline, these tests were expected to fail for reasons unrelated to this change. There is some work to do to resolve these PR tests.

[EDIT] Please see #258

@karianna karianna merged commit b79b7c7 into Azure:dev Oct 17, 2024
18 of 26 checks passed
@joe-braley joe-braley deleted the joe/component-upgrades branch October 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants