[db-up] Upgrade pymssql to support Python 3.10 #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
commented
Apr 1, 2022
|
db-up |
jiasli
reviewed
Apr 1, 2022
src/db-up/azext_db_up/custom.py
Outdated
| @@ -209,7 +209,7 @@ def _ensure_pymssql(): | |||
| python_path = os.environ.get('PYTHONPATH', '') | |||
| os.environ['PYTHONPATH'] = python_path + ':' + db_up_ext_path if python_path else db_up_ext_path | |||
| cmd = [sys.executable, '-m', 'pip', 'install', '--target', db_up_ext_path, | |||
| 'pymssql==2.2.2', '-vv', '--disable-pip-version-check', '--no-cache-dir'] | |||
| 'pymssql', '-vv', '--disable-pip-version-check', '--no-cache-dir'] | |||
There was a problem hiding this comment.
I'm also hesitant about this. But it's annoying to bump manually each time
There was a problem hiding this comment.
We are already manually bumming version in setup.py, right? If we want, we can loosen the version in both places.
|
|
jiasli
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4608
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.