Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AKS] Support updating from SPN cluster to MSI cluster #17902

Merged
merged 6 commits into from
Apr 29, 2021
Merged

[AKS] Support updating from SPN cluster to MSI cluster #17902

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8751527
Support update from SPN cluster to MSI cluster
norshtein Apr 28, 2021
43d9d52
Add test recording files
norshtein Apr 28, 2021
5d2bafd
Update test definition
norshtein Apr 28, 2021
7021282
Update recording file
norshtein Apr 28, 2021
4114f7a
Fix style
norshtein Apr 28, 2021
8d8bb7a
Fix style
norshtein Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix style
  • Loading branch information
@norshtein
norshtein committed Apr 28, 2021
commit 8d8bb7a7b03e932996bd8727781467b4c76d244d
30 changes: 15 additions & 15 deletions src/azure-cli/azure/cli/command_modules/acs/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2679,21 +2679,21 @@ def aks_update(cmd, client, resource_group_name, name,
instance.addon_profiles[CONST_VIRTUAL_NODE_ADDON_NAME + 'Linux'].enabled

return _put_managed_cluster_ensuring_permission(
cmd,
client,
subscription_id,
resource_group_name,
name,
instance,
monitoring_addon_enabled,
ingress_appgw_addon_enabled,
virtual_node_addon_enabled,
False,
instance.agent_pool_profiles[0].vnet_subnet_id,
_is_msi_cluster(instance),
attach_acr,
None,
no_wait)
cmd,
client,
subscription_id,
resource_group_name,
name,
instance,
monitoring_addon_enabled,
ingress_appgw_addon_enabled,
virtual_node_addon_enabled,
False,
instance.agent_pool_profiles[0].vnet_subnet_id,
_is_msi_cluster(instance),
attach_acr,
None,
no_wait)


# pylint: disable=unused-argument,inconsistent-return-statements,too-many-return-statements
Expand Down