{Packaging} Install pip in Homebrew virtual env #27186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebound
requested review from
kairu-ms,
jiasli,
wangzelin007 and
calvinhzy
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
jiasli
reviewed
Aug 24, 2023
| @@ -126,6 +126,11 @@ def update_formula() -> str: | |||
| upstream_sha = compute_sha256(HOMEBREW_UPSTREAM_URL) | |||
| text = re.sub('sha256 ".*"', 'sha256 "{}"'.format(upstream_sha), text, 1) | |||
| text = re.sub('.*revision.*\n', '', text, 1) # remove revision for previous version if exists | |||
|
|
|||
| # include pip when creating venv, see https://github.com/Azure/azure-cli/issues/27047 | |||
There was a problem hiding this comment.
It the link incorrect? #27047 doesn't seem to be related to pip in a venv.
There was a problem hiding this comment.
Update to homebrew pr link: Homebrew/brew#15792
jiasli
reviewed
Aug 24, 2023
|
|
||
| # include pip when creating venv, see https://github.com/Homebrew/brew/pull/15792 | ||
| # this can be removed after Homebrew merges our PR | ||
| text = re.sub('system_site_packages: false', 'system_site_packages: false, without_pip: false', text, 1) |
There was a problem hiding this comment.
As formula_generate.py always updates the formula on Homebrew side, it requires a weird process that we always need 2 separate PRs:
- one to make the change,
- once the change is merged to Homebrew side's formula, one without the change
An alternative I can think of is to directly submit a PR to https://github.com/Homebrew/homebrew-core/blob/master/Formula/a/azure-cli.rb
There was a problem hiding this comment.
We have to manually fix here as Homebrew pipeline is broken now.
Creating PR to homebrew is more convenient.
|
Homebrew/brew#15792 (comment) made a very good point.
|
jiasli
approved these changes
Aug 24, 2023
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Homebrew does not install pip when create venv in Homebrew/brew#15792, adding
without_pip: falseto install pip.pipalso installssetuptools, which is also required in namespace package:PS: In general, we can make this change in homebrew repo.
The homebrew formula is broken for now, and we're using the 2.50 formula. I have to make the change here.
Related issue:
setuptoolsto dependency #27196Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.