[Backup] Fix vault update immutability behaviour and add a new update command #27743
+3,261
−7,962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubairabid
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
🔄AzureCLI-FullTest
|
|
Hi @zubairabid, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup vault create | cmd backup vault create update parameter azure_monitor_alerts_for_job_failures: removed property default=Enable |
||
| backup vault create | cmd backup vault create update parameter classic_alerts: removed property default=Enable |
||
| backup vault update | cmd backup vault update added |
|
Backup |
zhoxing-ms
reviewed
Nov 6, 2023
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by xxx, otherwise the release of this PR will have to be postponed to the next sprint (on 12-05) |
Remove incorrect "crafted" tag. Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
zhoxing-ms
approved these changes
Nov 6, 2023
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
October 2023 (2023-11-14)❗ Breaking change release ❗
albertofori
pushed a commit
to albertofori/azure-cli
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az backup vault create/updateDescription
As resolution for incident 430801830, immutability options can now be modified for vaults with Managed Identity. In addition we are adding a
backup vault updatecommand as more and more vault properties are now updated through this interface, and to allow updating vault properties without the "location parameter". The older behaviour of updating throughbackup vault createwill remain for backwards compatibility; the new command is a wrapper over the old one.Testing Guide
az backup vault update -g sampleRG -v sampleVault --immutability-state Unlockedshould work. We have added tests to the test cases for backup vault.History Notes
[Backup]
az backup vault create: Allow updates to immutability for vaults with Managed Identity set[Backup]
az backup vault update: Add new command to support updating vault properties without the--locationparameterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.