CIT: to verify ReceivePump releases ThreadPool upon Close #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pending changes: * scrub codebase for pending whenCompleteAsync to handleAsync
…ver.receive().handle{...}
…into cit.receive.pump
sabeegrewal
added a commit
that referenced
this pull request
Jul 2, 2018
* Update version to 1.0.0 * reformat code (#284) * Add public method checkpoint(Checkpoint) to PartitionContext (#266) * Add public method checkpoint(Checkpoint) to PartitionContext for complex scenarios with manual checkpoint management which cannot affort to store the EventData object for a long time * Replaced private method PartitionContext::persistCheckpoint(Checkpoint) with public method checkpoint(Checkpoint) * Sanitize arguments to public checkpoint methods (#286) * Port offset fix from dotnet (#288) * Port fix from .NET * move the repo to next minor version snapshot (#290) * move repo to next version snapshot * Removing new EventData from docs and comments (#285) * Fix a receiver stuck issue caused by SetPrefetchCount > 1897 (#295) * fix bug in setPrefetchCount() * tests * bump up client version - for hotfix - as this fix will be needed by SPARK adapter * Update readme (#300) * fix samples link * update version info * Document partition ownership changes and event reprocessing scenarios. (#301) * Update readme.md * Switching appveyor links * Update readme.md * Improve EPH lease handling for large partition counts (#308) * First pass at making partition balancing faster, more efficient, able to cope with large numbers of partitions. * Fixes, test changes. * Refactor and optimize for large numbers of partitions * Fix issues and tune performance * fix a null pointer error in case owner info is not yet updated * Don't need isExpired method anymore. * Remove unneeded APIs * Remove APIs no longer present in the interfaces * Minor tweaks and fixes * Test updates for changed manager APIs * Turn info tracing down to debug * improve PartitionReceiver.getRuntimeInfo javadoc (#313) * Implement client timeout for getRuntimeInformation API (#314) * Treat session timeouts as transient (#315) * fix reactor recovery codepath upon unhandled exceptions thrown from proton fx (#316) * Change receivePump to start using Executor provided to EventHubClient (#317) * move whenCompleteAsync's usage to handleAsync * logs first, error handlers next! * optimize extra Runnable objects created for `ReceivePump` * fix scheduling issue - reschedule should happen inside partitionReceiver.receive().handle{...} * CIT: to verify ReceivePump releases ThreadPool upon Close (#322) * Refactor session timeout error to be TimeoutException instead of EventHubException (#325) * Fixes for shutdown issues (#321) * Turn off some test cases for automation * Added Closable to make shutdown more coherent * Fixed leak of EventHubClient from getting partition ids I will address Sreeram's feedback in the next PR * Fit and finish for Java EPH 2.0.0 release (#330) * Update all tests, should work with maven and appveyor now or skip. * Add or improve JavaDocs * Make EPH.unregisterEventProcessor idempotent * Fit and finish: rename Pump to PumpManager to reflect actual function * JavaDocs for PartitionManagerOptions * Test fixes * Address comment: make member volatile * Before scheduling task on ReactorDispatcher - verify that its not closed (#331) * Establish new hierarchy of lease classes (#340) * Establish new hierary of lease classes BaseLease is minimum information required by PartitionScanner so that ILeaseManager.getAllLeases can be fast CompleteLease is base class for implementation-specific classes and indicates that all lease info is present * JavaDocs update for ILeaseManager * Preserve epoch when cloning in-memory lease * Prep for EPH 2.0.0 release (#341) * Handle CompletionException in ManagementRetry * Remove put token messaging on request failures (#346) * Prepare for 1.0.2 release
Jgomez13
pushed a commit
that referenced
this pull request
May 17, 2024
Jgomez13
pushed a commit
that referenced
this pull request
May 17, 2024
* Update version to 1.0.0 * reformat code (#284) * Add public method checkpoint(Checkpoint) to PartitionContext (#266) * Add public method checkpoint(Checkpoint) to PartitionContext for complex scenarios with manual checkpoint management which cannot affort to store the EventData object for a long time * Replaced private method PartitionContext::persistCheckpoint(Checkpoint) with public method checkpoint(Checkpoint) * Sanitize arguments to public checkpoint methods (#286) * Port offset fix from dotnet (#288) * Port fix from .NET * move the repo to next minor version snapshot (#290) * move repo to next version snapshot * Removing new EventData from docs and comments (#285) * Fix a receiver stuck issue caused by SetPrefetchCount > 1897 (#295) * fix bug in setPrefetchCount() * tests * bump up client version - for hotfix - as this fix will be needed by SPARK adapter * Update readme (#300) * fix samples link * update version info * Document partition ownership changes and event reprocessing scenarios. (#301) * Update readme.md * Switching appveyor links * Update readme.md * Improve EPH lease handling for large partition counts (#308) * First pass at making partition balancing faster, more efficient, able to cope with large numbers of partitions. * Fixes, test changes. * Refactor and optimize for large numbers of partitions * Fix issues and tune performance * fix a null pointer error in case owner info is not yet updated * Don't need isExpired method anymore. * Remove unneeded APIs * Remove APIs no longer present in the interfaces * Minor tweaks and fixes * Test updates for changed manager APIs * Turn info tracing down to debug * improve PartitionReceiver.getRuntimeInfo javadoc (#313) * Implement client timeout for getRuntimeInformation API (#314) * Treat session timeouts as transient (#315) * fix reactor recovery codepath upon unhandled exceptions thrown from proton fx (#316) * Change receivePump to start using Executor provided to EventHubClient (#317) * move whenCompleteAsync's usage to handleAsync * logs first, error handlers next! * optimize extra Runnable objects created for `ReceivePump` * fix scheduling issue - reschedule should happen inside partitionReceiver.receive().handle{...} * CIT: to verify ReceivePump releases ThreadPool upon Close (#322) * Refactor session timeout error to be TimeoutException instead of EventHubException (#325) * Fixes for shutdown issues (#321) * Turn off some test cases for automation * Added Closable to make shutdown more coherent * Fixed leak of EventHubClient from getting partition ids I will address Sreeram's feedback in the next PR * Fit and finish for Java EPH 2.0.0 release (#330) * Update all tests, should work with maven and appveyor now or skip. * Add or improve JavaDocs * Make EPH.unregisterEventProcessor idempotent * Fit and finish: rename Pump to PumpManager to reflect actual function * JavaDocs for PartitionManagerOptions * Test fixes * Address comment: make member volatile * Before scheduling task on ReactorDispatcher - verify that its not closed (#331) * Establish new hierarchy of lease classes (#340) * Establish new hierary of lease classes BaseLease is minimum information required by PartitionScanner so that ILeaseManager.getAllLeases can be fast CompleteLease is base class for implementation-specific classes and indicates that all lease info is present * JavaDocs update for ILeaseManager * Preserve epoch when cloning in-memory lease * Prep for EPH 2.0.0 release (#341) * Handle CompletionException in ManagementRetry * Remove put token messaging on request failures (#346) * Prepare for 1.0.2 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.