Adding CLI script for GeoDR with no update to existing clients #381
Conversation
ShubhaVijayasarathy
assigned ShubhaVijayasarathy, sabeegrewal and SreeramGarlapati and unassigned ShubhaVijayasarathy
There was a problem hiding this comment.
Thanks for driving this & the gr8 work @ShubhaVijayasarathy !! few changes away from awsmness.!
Please take @sjkwak 's help to get GEO DR changes reviewed.
| @@ -0,0 +1,30 @@ | |||
| # Receive events from Azure Event Hubs using Java | |||
|
|
|||
| This sample shows how to receive events from a particular Event Hub partition based on a sequence number. This is a lower-level API gesture that most applications will not use, but rather lean on the Event Processor Host to manage partition ownership and check-pointing. The [Event Processor Sample](../EventProcessorSample) shows this higher level functionality. | |||
There was a problem hiding this comment.
please see if we can get 1 critical info straight out to customer:
- Creating receiver based on sequence# is expensive. To get best performance - create one based on Offset. Creating by seq# - service internally tries to resolve this to Offset.
| // Send - not tied to any partition | ||
| // EventHubs service will round-robin the events across all EventHubs partitions. | ||
| // This is the recommended & most reliable way to send to EventHubs. | ||
| ehClient.send(sendEvent).get(); |
There was a problem hiding this comment.
use ehClient.sendSync() variant instead of send(..).get();
| System.out.println(Instant.now() + ": Send Complete..."); | ||
| System.in.read(); | ||
| } finally { | ||
| ehClient.closeSync(); |
There was a problem hiding this comment.
add comment here - to elaborate that - ehClient can be repetitively used to send for longer duration & that ehClient.closeSync() cleans up resources - io/socket.
Since, ehClient creation involves creating a connection and ssl hand-shake with service - its an expense operation.
| * **SendBatch** - The [SendBatch](./Basic/SendBatch) sample illustrates how to ingest batches of events into your event hub. | ||
| * **SimpleSend** - The [SimpleSend](./Basic/SimpleSend) sample illustrates how to ingest events into your event hub. |
There was a problem hiding this comment.
consider renaming this to
send - this feels like what is shown in simple send.
sendBatch
advancedSend - add partition scenarios here - and provide guidance that - these types of sends comes with more partition control and lower availability.
| </build> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.microsoft.azure</groupId> |
There was a problem hiding this comment.
use latest version1.0.1
|
|
||
| final Gson gson = new GsonBuilder().create(); | ||
|
|
||
| final ExecutorService executorService = Executors.newSingleThreadExecutor(); |
There was a problem hiding this comment.
add a comment here to provide guidance on executorservice.
mention that - we used single thread executor - as there is only 1 EHclient created for this simple sample. But, in general - customers will need to think thru and model their thread pool size - and can share the ExecutorService across multiple EHClient instances.
There was a problem hiding this comment.
this could probably cater to all samples.
There was a problem hiding this comment.
will try to keep this sample simple and add the details to the other send options.
There was a problem hiding this comment.
I expect this sample to be used the most! so, please see if you can add this critical detail.
There was a problem hiding this comment.
Added. Let me if it sounds about right. And for PS and CLI scripts for Geo-DR, they have been tested before adding here :)
| @@ -0,0 +1,30 @@ | |||
| # Receive events from Azure Event Hubs using Java | |||
|
|
|||
| This sample shows how to receive events from a particular Event Hub partition based on a sequence number. This is a lower-level API gesture that most applications will not use, but rather lean on the Event Processor Host to manage partition ownership and check-pointing. The [Event Processor Sample](../EventProcessorSample) shows this higher level functionality. | |||
There was a problem hiding this comment.
I would love to see if we can elaborate "lower-level api gesture".
Briefly explain - that since, each eventhub have multiple partitions - and since this receiver can only receive off of a single partition - we also provide a library - which developers can use to receive off of all partitions.
There was a problem hiding this comment.
Ack, will update the changes. Thank you :)
Adding CLI script for Geo DR