Analyzer for Multiple-Output Binding Scenarios with ASP.NET Core Integration #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
commented
Sep 12, 2024
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs
Show resolved
Hide resolved
liliankasem
reviewed
Sep 12, 2024
liliankasem
reviewed
Sep 12, 2024
...sions/Worker.Extensions.Http.AspNetCore.Analyzers/src/HttpResultAttributeExpectedAnalyzer.cs
Outdated
Show resolved
Hide resolved
liliankasem
reviewed
Sep 12, 2024
test/extensions/Worker.Extensions.Http.AspNetCore.Tests/HttpResultAttributeExpectedTests.cs
Outdated
Show resolved
Hide resolved
|
Can you include a screenshot/gif in the PR desc of this analyzer working? |
liliankasem
reviewed
Sep 12, 2024
extensions/Worker.Extensions.Http.AspNetCore.Analyzers/src/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
kshyju
reviewed
Sep 13, 2024
...sions/Worker.Extensions.Http.AspNetCore.Analyzers/src/HttpResultAttributeExpectedAnalyzer.cs
Outdated
Show resolved
Hide resolved
kshyju
reviewed
Sep 13, 2024
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs
Outdated
Show resolved
Hide resolved
kshyju
reviewed
Sep 13, 2024
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs
Outdated
Show resolved
Hide resolved
kshyju
reviewed
Sep 13, 2024
liliankasem
reviewed
Sep 16, 2024
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs
Outdated
Show resolved
Hide resolved
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs
Show resolved
Hide resolved
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http.AspNetCore.Analyzers/src/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
| namespace Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore | ||
| { | ||
| internal static class ITypeSymbolExtensions | ||
| { |
There was a problem hiding this comment.
Does this method need to take into account interfaces at all?
There was a problem hiding this comment.
Given that OutputBindingAttribute is not an interface, this will successfully find classes that implement the abstract class.
For classes that implement some interface, this should just exit (BaseType returns null).
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore | ||
| { | ||
| internal static class ITypeSymbolExtensions |
There was a problem hiding this comment.
please create a unit test for this this file and test the IsOrDerivedFrom method (should be done for all helper methods/extensions)
There was a problem hiding this comment.
Leaving this for another iteration - need to investigate how to best test this as we may need access to a compilation and semantic model.
liliankasem
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2352
Pull request checklist
release_notes.mdAdditional Information
Screenshots of the alert and code-fix.