[ReleasePR notificationhubs] [Hub Generated] Review request for Microsoft.NotificationHubs to add version preview/2023-01-01-preview #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Hub Generated] Review request for Microsoft.NotificationHubs to add version preview/2023-01-01-preview (#24072) * Adds base for updating Microsoft.NotificationHubs from version stable/2017-04-01 to version 2023-01-01-preview * Updates readme * Updates API version in new specs and examples * Notification Hubs: adding API version 2023-01-01-preview * Notification Hubs: udpating custom words * Notification Hubs: updating custom-words * Changing zoneRedundant (boolean) to zoneRedundancy (enum), making Network ACLs optional * Notification Hubs: updating examples * Notification Hubs: fixing property name * Notification Hubs: fixing examples * Notification Hubs: resolving some of PR comments * Notification Hubs: adding x-ms-long-running-operation to one of Private Link operations * Notification Hubs: removing internal MoveResourceRequest * Notification Hubs: fixing merge marker * Notification Hubs: fixing zoneRedundancy * Notification Hubs: updating Swagger * Notification Hubs: updating samples * Notification Hubs: renaming $count to $top * Notification Hubs: removing 200 response from PrivateEndpointConnection.Delete * Notification Hubs: fixing async operation annotations * NotificationHubs: suppressing linter error * Notification Hubs: fixing async operation annotations * Notification Hubs: fixing async operation annotations * Notification Hubs: removing 201 for three operations * Notification Hubs: adding back response 201 for Notification Hubs - Create or Update * Notification Hubs: cleanup in 201 status codes * Notification Hubs: updating ids in examples * Notification Hubs: updating two examples
11 tasks
ghost
added
the
ghost
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.
|
Hello @msftbot[bot]! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#24072
ReCreate this PR