[Hub Generated] Publish private branch 'appplatform/release/05-01-preview' #19057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multi-version config
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/7138 |
Caoxuyang
requested review from
msyyc,
BigCat20196 and
ArcturusZhang
as code owners
|
Hi @Caoxuyang, this service has enabled Shift Left. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth. |
|
Hi, @Caoxuyang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: logStreamPublicEndpoint Location: Microsoft.AppPlatform/preview/2022-05-01-preview/appplatform.json#L7677 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: publicEndpoint Location: Microsoft.AppPlatform/preview/2022-05-01-preview/appplatform.json#L8042 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableProbe Location: Microsoft.AppPlatform/preview/2022-05-01-preview/appplatform.json#L8960 |
The following errors/warnings exist before current PR submission:
Only 28 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 56 Errors, 271 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2022-05-01-preview/appplatform.json compared with base:stable/2020-07-01/appplatform.json
- current:preview/2022-05-01-preview/appplatform.json compared with base:preview/2022-03-01-preview/appplatform.json
- current:stable/2022-04-01/appplatform.json compared with base:stable/2020-07-01/appplatform.json
- current:stable/2022-04-01/appplatform.json compared with base:preview/2022-03-01-preview/appplatform.json
Only 28 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 28 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/stop' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L409:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/start' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L460:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/storages/{storageName}' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L3254:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/storages' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L3417:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways/{gatewayName}' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5003:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5160:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways/{gatewayName}/routeConfigs/{routeConfigName}' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5205:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways/{gatewayName}/routeConfigs' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5371:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways/{gatewayName}/domains/{domainName}' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5419:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways/{gatewayName}/domains' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5585:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/gateways/{gatewayName}/validateDomain' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5633:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apiPortals/{apiPortalName}' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5687:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apiPortals' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5844:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apiPortals/{apiPortalName}/domains/{domainName}' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L5889:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apiPortals/{apiPortalName}/domains' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6055:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apiPortals/{apiPortalName}/validateDomain' removed or restructured? Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6103:5 |
|
| The new version is missing a definition that was found in the old version. Was 'UserAssignedManagedIdentities' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'StorageResource' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'StorageProperties' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'StorageAccount' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CustomPersistentDiskCollection' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AzureFileVolume' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CustomContainerUserSourceInfo' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CustomContainer' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ImageRegistryCredential' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ContainerProbeSettings' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'GatewayResource' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
|
| The new version is missing a definition that was found in the old version. Was 'GatewayProperties' removed or renamed? New: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L4685:3 Old: Microsoft.AppPlatform/preview/2022-03-01-preview/appplatform.json#L6158:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @Caoxuyang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced May 13, 2022
yuwzho
reviewed
May 13, 2022
yuwzho
approved these changes
May 16, 2022
raych1
approved these changes
May 16, 2022
This was referenced May 16, 2022
This was referenced May 16, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
May 16, 2022
…atform/release/05-01-preview' (#2375) Create to sync Azure/azure-rest-api-specs#19057 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/appplatform?expand=1)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…view' (Azure#19057) * [AutoSync] bff534817 Merged PR 6051224: feat: add acis for lifecycle multi-version config * revert changes Co-authored-by: swagger-automation <swagger@microsoft.com> Co-authored-by: Xuyang Cao <xuycao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.