Update readme.python.md #22401

msyyc · 2023-02-01T05:27:20Z

https://github.com/Azure/sdk-release-request/issues/3732

openapi-workflow-bot · 2023-02-01T05:27:23Z

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-02-01T05:27:23Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️🔄CredScan inProgress [Detail]

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.0.0)	new version	base version
default	default(c850e89)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️🔄PoliCheck inProgress [Detail]

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-01T05:27:24Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from c591889. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-storagemover [View full logs] [Release SDK Changes]
- azure_mgmt_storagemover-1.0.0b1-py3-none-any.whl
- azure-mgmt-storagemover-1.0.0b1.zip
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from c591889. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-storagemover [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c591889. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/storagemover/armstoragemover [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c591889. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-storagemover [View full logs] [Release SDK Changes]
- azure-arm-storagemover-1.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from c591889. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️storagemover [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-01T05:27:25Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/storagemover/armstoragemover	https://apiview.dev/Assemblies/Review/b1951c829f06487ea0f96dd9e59ae377
Java	azure-resourcemanager-storagemover	https://apiview.dev/Assemblies/Review/1c50a1639b82453cbb08517f930aa68a
JavaScript	@azure/arm-storagemover	https://apiview.dev/Assemblies/Review/c750f3688e2a4f32be9811799614a8cf

changlong-liu · 2023-02-01T05:33:42Z

specification/storagemover/resource-manager/readme.python.md

@@ -3,21 +3,16 @@
 These settings apply only when `--python` is specified on the command line.
 Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`.

-``` yaml $(track2)
+``` yaml $(python)


Hi @msyyc , I'm wonderring shall we merge line 6~18 to same yaml block?

we want keep same with template file and existing python.md

changlong-liu · 2023-02-01T05:34:02Z

specification/storagemover/resource-manager/readme.python.md

 package-version: 1.0.0b1
 clear-output-folder: true
 ```

-``` yaml $(python-mode) == 'update' && $(track2)
+``` yaml $(python)
 no-namespace-folders: true


Do we still need this line?

Yes. It is related with autorest behavior.

Update readme.python.md

c850e89

msyyc requested a review from Wzb123456789 as a code owner February 1, 2023 05:27

msyyc self-assigned this Feb 1, 2023

changlong-liu reviewed Feb 1, 2023

View reviewed changes

AzureRestAPISpecReview added resource-manager RPaaS labels Feb 1, 2023

Wzb123456789 approved these changes Feb 1, 2023

View reviewed changes

azure-sdk mentioned this pull request Feb 1, 2023

[AutoPR @azure/arm-storagemover] Update readme.python.md azure-sdk/azure-sdk-for-js#3653

Closed

msyyc merged commit c591889 into main Feb 1, 2023

msyyc deleted the msyyc-patch-1 branch February 1, 2023 05:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update readme.python.md #22401

Update readme.python.md #22401

msyyc commented Feb 1, 2023

openapi-workflow-bot bot commented Feb 1, 2023

openapi-pipeline-app bot commented Feb 1, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 1, 2023 •

edited

Loading

changlong-liu Feb 1, 2023

msyyc Feb 1, 2023

changlong-liu Feb 1, 2023

msyyc Feb 1, 2023

Update readme.python.md #22401

Update readme.python.md #22401

Conversation

msyyc commented Feb 1, 2023

openapi-workflow-bot bot commented Feb 1, 2023

openapi-pipeline-app bot commented Feb 1, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 1, 2023 • edited Loading

Generated ApiView

changlong-liu Feb 1, 2023

Choose a reason for hiding this comment

msyyc Feb 1, 2023

Choose a reason for hiding this comment

changlong-liu Feb 1, 2023

Choose a reason for hiding this comment

msyyc Feb 1, 2023

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Feb 1, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2023 •

edited

Loading