Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks/2022 08 01 preview #24157

Merged
merged 4 commits into from
May 30, 2023

Conversation

harshpatel17
Copy link
Contributor

@harshpatel17 harshpatel17 commented May 25, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @harshpatel17 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    deploymentStacks.json 2022-08-01-preview(5514c8e) 2022-08-01-preview(main)
    Rule Message
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L1056:7
    Old: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L1053:7
    1034 - AddedRequiredProperty The new version has new required property 'mode' that was not found in the old version.
    New: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L846:9
    Old: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L846:9
    1034 - AddedRequiredProperty The new version has new required property 'mode' that was not found in the old version.
    New: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L1050:5
    Old: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L1050:5
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-deploymentstacks-2022-08-preview package-deploymentstacks-2022-08-preview(5514c8e) package-deploymentstacks-2022-08-preview(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsAPIImplementation Operations API must be implemented for 'Microsoft.Resources'.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L1
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L67
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L106
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L145
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L209
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L212
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L249
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L307
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L310
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L316
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L365
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L368
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L402
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L457
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L460
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L466
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L515
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L518
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L552
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L610
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L613
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L652
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L691
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L730
    TrackedResourcePatchOperation Tracked resource 'DeploymentStack' must have patch operation that at least supports the update of tags.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L741
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: DeploymentStacksList
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L86
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: DeploymentStacksList
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L125
    ⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L293
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: DeploymentStacksCreateOrUpdate
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L327
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: DeploymentStacksGet
    Location: Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json#L379
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/resources/armresources - Approved - 2.0.0
    +	Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
    +	Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
    +	Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.









    azure-sdk-for-js - @azure/arm-changes - Approved - 2.0.0
    +	Interface ChangesListNextOptionalParams no longer has parameter skipToken
    +	Interface ChangesListNextOptionalParams no longer has parameter top
    azure-sdk-for-js - @azure/arm-links - Approved - 3.0.0
    +	Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter
    azure-sdk-for-js - @azure/arm-locks - Approved - 3.0.0
    +	Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
    +	Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
    +	Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
    +	Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter
    azure-sdk-for-js - @azure/arm-policy - Approved - 6.0.0-beta.1
    +	Class PolicyClient has a new signature
    +	Parameter subscriptionId of class PolicyClient is now required

    azure-sdk-for-js - @azure/arm-resources - Approved - 6.0.0
    +	Removed operation TagsOperations.createOrUpdateAtScope
    +	Removed operation TagsOperations.deleteAtScope
    +	Removed operation TagsOperations.updateAtScope
    azure-sdk-for-js - @azure/arm-templatespecs - Approved - 3.0.0
    +	Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
    +	Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand
    azure-sdk-for-python-track2 - track2_azure-mgmt-resource - Approved - 23.1.0b1
    +	Parameter mode of model DenySettings is now required
    ️⚠️ azure-sdk-for-net-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 13bf172. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️Azure.ResourceManager.Resources [View full logs
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 13bf172. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-resource [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Parameter mode of model DenySettings is now required
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 13bf172. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/resources/armresources [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
      info	[Changelog] - Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
      info	[Changelog] - Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armdeploymentscripts [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armfeatures [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armlinks [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armlocks [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armmanagedapplications [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armpolicy [View full logs]  [Release SDK Changes]
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - New struct `VariableColumn`
      info	[Changelog] - New struct `VariableListResult`
      info	[Changelog] - New struct `VariableProperties`
      info	[Changelog] - New struct `VariableValue`
      info	[Changelog] - New struct `VariableValueColumnValue`
      info	[Changelog] - New struct `VariableValueListResult`
      info	[Changelog] - New struct `VariableValueProperties`
      info	[Changelog] - New field `Overrides`, `ResourceSelectors` in struct `AssignmentProperties`
      info	[Changelog] - New field `Properties` in struct `AssignmentUpdate`
      info	[Changelog] - New field `AssignmentScopeValidation`, `ResourceSelectors` in struct `ExemptionProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 62 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armsubscriptions [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armtemplatespecs [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armchanges [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 13bf172. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-changes [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter top
    • ️✔️@azure/arm-features [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-links [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter
    • ️✔️@azure/arm-locks [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter
    • ️✔️@azure/arm-managedapplications [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-policy [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog]   - Interface PolicyAssignment has a new optional parameter overrides
      info	[Changelog]   - Interface PolicyAssignment has a new optional parameter resourceSelectors
      info	[Changelog]   - Interface PolicyAssignmentUpdate has a new optional parameter overrides
      info	[Changelog]   - Interface PolicyAssignmentUpdate has a new optional parameter resourceSelectors
      info	[Changelog]   - Interface PolicyExemption has a new optional parameter assignmentScopeValidation
      info	[Changelog]   - Interface PolicyExemption has a new optional parameter resourceSelectors
      info	[Changelog]   - Added Enum KnownAssignmentScopeValidation
      info	[Changelog]   - Added Enum KnownOverrideKind
      info	[Changelog]   - Added Enum KnownSelectorKind
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class PolicyClient has a new signature
      info	[Changelog]   - Parameter subscriptionId of class PolicyClient is now required
    • ️✔️@azure/arm-resources-subscriptions [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-resources [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog]   - Added Interface TagsDeleteAtScopeHeaders
      info	[Changelog]   - Added Interface TagsUpdateAtScopeHeaders
      info	[Changelog]   - Interface TagsCreateOrUpdateAtScopeOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface TagsCreateOrUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation TagsOperations.createOrUpdateAtScope
      info	[Changelog]   - Removed operation TagsOperations.deleteAtScope
      info	[Changelog]   - Removed operation TagsOperations.updateAtScope
    • ️✔️@azure/arm-templatespecs [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog]   - Added Interface TemplateSpecVersionsGetBuiltInOptionalParams
      info	[Changelog]   - Added Interface TemplateSpecVersionsListBuiltInsNextOptionalParams
      info	[Changelog]   - Added Interface TemplateSpecVersionsListBuiltInsOptionalParams
      info	[Changelog]   - Added Type Alias TemplateSpecsGetBuiltInResponse
      info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsNextResponse
      info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsResponse
      info	[Changelog]   - Added Type Alias TemplateSpecVersionsGetBuiltInResponse
      info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsNextResponse
      info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsResponse
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 13bf172. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
    • ️✔️resources [View full logs]  [Release Schema Changes]
    • ️✔️resources [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		resources
      error		resources
      error		resources
      error		resources
    • ️✔️resources
    • ️✔️resources
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 13bf172. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.resources.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.resources.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
    Go sdk/resourcemanager/resources/armdeploymentscripts https://apiview.dev/Assemblies/Review/9c4470537d7049b8b0f60a4f8f109ecf
    Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
    Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
    Java azure-resourcemanager-resources-generated https://apiview.dev/Assemblies/Review/bf2180a3532640b6a4cac44c8673715f
    Go sdk/resourcemanager/resources/armlocks There is no API change compared with the previous version
    Go sdk/resourcemanager/resources/armmanagedapplications https://apiview.dev/Assemblies/Review/4969e4a072974eaeb014348bdea33efd
    Go sdk/resourcemanager/resources/armpolicy https://apiview.dev/Assemblies/Review/519dd1c49ded4e2483671cff91c22a33
    Go sdk/resourcemanager/resources/armresources https://apiview.dev/Assemblies/Review/e249a1fecbb0419f8a2479fc7aa4d2b5
    Go sdk/resourcemanager/resources/armsubscriptions https://apiview.dev/Assemblies/Review/222d33b66d8d471cbb47175b22663c24
    Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
    .Net Azure.ResourceManager.Resources There is no API change compared with the previous version
    JavaScript @azure/arm-changes https://apiview.dev/Assemblies/Review/fe98c0eaa41a4902ac1ff0b8a2aa6f22
    JavaScript @azure/arm-features https://apiview.dev/Assemblies/Review/65a9590ee11941e7b767933e69721fe7
    JavaScript @azure/arm-links https://apiview.dev/Assemblies/Review/88bfe016e7074a188c696992794c5f65
    JavaScript @azure/arm-locks https://apiview.dev/Assemblies/Review/e857fb05b7a3498ea577d40d3eb80394
    JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/2e42900614134b08aab48b3abfa2b7b4
    JavaScript @azure/arm-policy https://apiview.dev/Assemblies/Review/97dcbac72e0c47c58d06af45ec9dc2f5
    JavaScript @azure/arm-resources-subscriptions https://apiview.dev/Assemblies/Review/1296f588ac424327bf2d42bf95f88ad5
    JavaScript @azure/arm-resources https://apiview.dev/Assemblies/Review/49d06e69ecaa486e9fd44a1c0736bab7
    JavaScript @azure/arm-templatespecs https://apiview.dev/Assemblies/Review/acd3b6497a3e4e99a88d37c0f198e85f

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels May 25, 2023
    @openapi-workflow-bot
    Copy link

    Hi @harshpatel17, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @kazrael2119
    Copy link
    Contributor

    @msyyc @tadelesh @qiaozha , please help review sdk breaking changes, thanks

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 29, 2023
    @XiaofeiCao
    Copy link
    Contributor

    Thanks Mike!

    @XiaofeiCao XiaofeiCao merged commit 13bf172 into Azure:main May 30, 2023
    This was referenced May 30, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants