Add feature store api's to GA version #25594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Aug 30, 2023
were all these sorting changes required? they make it hard to see and review the main change. got any commits I can review which make the intended change more obvious? #Resolved Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:46 in 38f5c85. [](commit_id = 38f5c85, deletion_comment = False) |
I think additionalProperties false should be the default, so you could probably skip declaring it - or is there a code generator involved here? #Resolved Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:12738 in a720f38. [](commit_id = a720f38, deletion_comment = False) |
DTO would be an acronym so should be capitalized I assume? #Resolved In reply to: 1718295014 Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:13751 in a720f38. [](commit_id = a720f38, deletion_comment = False) |
Can you call it something simpler - e.g. FeatureResourceList? FeatureListResult? In reply to: 1718295906 Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:13860 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
Please inherit TrackedResource or ProxyResource, to clarify your intended behavior, not just Resource. #Resolved Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:13848 in 38f5c85. [](commit_id = 38f5c85, deletion_comment = False) |
Can you call it something simpler - e.g. FeaturesetVersionList? FeaturesetVersionListResult? FeaturesetVersionListResultsPage? In reply to: 1718298264 Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:14106 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
Please see if you can get someone to review your documentation for style in parallel, and whether e.g. this is ok Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:14111 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
ProxyResource? Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:14226 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
This should not be your description of your FeaturestoreEntityVersion resource right? Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:14219 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
I'd recommend not using 'Resource' suffix in the name if possible - its pretty meaningless. Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:14218 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
I'd recommend not using 'Resource' suffix in the name if possible - its pretty meaningless. Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:14145 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
I'd recommend not using 'Resource' suffix in the name if possible - its pretty meaningless. Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:13938 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
we recommend NOT using x-nullable. Consider making the property optional instead (but it already is, isn't it.) Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:19825 in 0a36fbe. [](commit_id = 0a36fbeeb9e7c7b3a8d3de1677c3ab0c285ee24b, deletion_comment = False) |
TimLovellSmith
added
the
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
shail2208
added
resource-manager
and removed
Network - Traffic Manager
Subscription
StorageSync
Synapses
Profile
I followed up with Tim offline, as still trying to understand why using "ProxyResource" is not a viable option here instead of just "Resource"? #Resolved Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:15119 in a720f38. [](commit_id = a720f38, deletion_comment = False) |
visingla-ms
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
shail2208
added
WaitForARMFeedback
Vikas, I have updated to ProxyResouorce. And also created two other PRs to modify to Proxy resource for other API versions. |
Decided to stay with the current naming conventions since we are using the same conventions across all the resources, which are already GAed. Synced with Tim for those. |
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
visingla-ms
approved these changes
Sep 22, 2023
visingla-ms
merged commit 0479ab1
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01
25 of 26 checks passed
kseager
pushed a commit
to kseager/azure-rest-api-specs
that referenced
this pull request
Oct 4, 2023
* Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com>
kseager
pushed a commit
to kseager/azure-rest-api-specs
that referenced
this pull request
Oct 6, 2023
* Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com>
rkmanda
pushed a commit
that referenced
this pull request
Oct 16, 2023
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <kaseager@microsoft.com> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: Chunyu Li <79233053+ChunyuMSFT@users.noreply.github.com> Co-authored-by: shail2208 <59747407+shail2208@users.noreply.github.com> Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: ac923 <aahelic@yahoo.com> Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> Co-authored-by: chaoyu-msft <93601904+chaoyu-msft@users.noreply.github.com> Co-authored-by: Mathieu St-Louis <81435026+mastloui-msft@users.noreply.github.com>
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <kaseager@microsoft.com> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: Chunyu Li <79233053+ChunyuMSFT@users.noreply.github.com> Co-authored-by: shail2208 <59747407+shail2208@users.noreply.github.com> Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: ac923 <aahelic@yahoo.com> Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> Co-authored-by: chaoyu-msft <93601904+chaoyu-msft@users.noreply.github.com> Co-authored-by: Mathieu St-Louis <81435026+mastloui-msft@users.noreply.github.com>
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <kaseager@microsoft.com> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: Chunyu Li <79233053+ChunyuMSFT@users.noreply.github.com> Co-authored-by: shail2208 <59747407+shail2208@users.noreply.github.com> Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: ac923 <aahelic@yahoo.com> Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> Co-authored-by: chaoyu-msft <93601904+chaoyu-msft@users.noreply.github.com> Co-authored-by: Mathieu St-Louis <81435026+mastloui-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.