Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut over to 1ES hosted pools for Java pipelines #18432

Merged
merged 10 commits into from
Jan 11, 2021
Merged

Cut over to 1ES hosted pools for Java pipelines #18432

merged 10 commits into from
Jan 11, 2021

Conversation

mitchdenny
Copy link
Contributor

This PR contains the necessary changes to cut over to the 1ES hosted pools for the Java pipelines. The top level changes are:

  1. Swap to long form parameter declarations (- name:, type: etc)
  2. Introduction of LinuxPool and WindowsPool parameters to stage and job template.
  3. Changes to job template to use these values.

@mitchdenny
Copy link
Contributor Author

/azp java - core - ci

@azure-pipelines
Copy link

Command 'java' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@check-enforcer
Copy link

check-enforcer bot commented Jan 5, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

Azure/azure-sdk-tools#1313

@mitchdenny
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - storage

@mitchdenny
Copy link
Contributor Author

/azp run java - cosmos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit 29e68f8 into Azure:master Jan 11, 2021
@mitchdenny mitchdenny deleted the enable-1es-hosted-pools branch January 11, 2021 23:30
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Apr 19, 2022
CodeGen from PR 18432 in Azure/azure-rest-api-specs
8adeff4 
Update resource association swagger (Azure#18432)

* update access mode values

* update examples

* Add 202 in delete spec

* Add provisioning issues changes

* update schema

* review changs

* update

* typo in model fix

* make provisioning issues readonly

* Add one example in list association, provisioning state enum update

* Add logggin categories in profile

* examples update

* update

* update examples

* reformat code

* Add x-msidentifier for logger

* update

* provisioning state fix

* Fix provisioning state

* Add location header in delete nsp association

* update location header

* update location header

* location header update

Co-authored-by: Kaushal Kumar <kumarkaushal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@alzimmermsft alzimmermsft alzimmermsft left review comments

@danieljurek danieljurek Awaiting requested review from danieljurek

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @weshaggard @alzimmermsft