Skip to content

Commit

Permalink
[identity] Disable broken IBC test (#28374)
Browse files Browse the repository at this point in the history
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

28373

### Describe the problem that is addressed by this PR

A more conservative version
#28346. I will document my
learnings in this issue
but the original PR also contains useful context to how we ended up here

### Checklists
- [x] Added impacted package name to the issue description
- [x] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
  • Loading branch information
maorleger authored Jan 25, 2024
1 parent 8c002aa commit e9c8ab2
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ describe("InteractiveBrowserCredential (internal)", function () {

const scope = "https://vault.azure.net/.default";

it("Throws an expected error if no browser is available", async function (this: Context) {
// TODO: re-enable this when we resolve the esm incompatibility issues
// https://github.com/Azure/azure-sdk-for-js/issues/28373
it.skip("Throws an expected error if no browser is available", async function (this: Context) {
// The SinonStub type does not include this second parameter to throws().
const testErrorMessage = "No browsers available on this test.";
(sandbox.stub(interactiveBrowserMockable, "open") as any).throws(
Expand Down

0 comments on commit e9c8ab2

Please sign in to comment.