Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-instrumentation-azure-sdk] Adopt OpenTelemetry HTTP semconv 1.23.1 #27585

Open
Tracked by #27588
lmolkova opened this issue Oct 28, 2023 · 6 comments
Open
Tracked by #27588
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific). For the issues related to the @azure/ope OpenTelemetryInstrumentation

Comments

@lmolkova
Copy link
Member

Update HTTP attributes to comply with HTTP semconv vTBD (likely 1.23.0 will declare them as stable):

  1. Rename attributes according to docs:
    • http.method -> http.request.method
    • http.status_code -> http.response.status_code
    • net.peer.name -> server.address
    • net.peer.port -> server.port
    • http.url -> url.full
    • http.user_agent -> user_agent.original
  2. Add new attributes:
  3. Update HTTP span names according to the new conventions
  4. Check if there is anything else in the list of changes that needs attention
@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific). For the issues related to the @azure/ope OpenTelemetryInstrumentation labels Oct 28, 2023
@lmolkova lmolkova changed the title [opentelemetry-instrumentation-azure-sdk] Adopt OpenTelemetry HTTP semconv vTBD [opentelemetry-instrumentation-azure-sdk] Adopt OpenTelemetry HTTP semconv 1.23.1 Mar 4, 2024
@maorleger
Copy link
Member

@lmolkova hi! Any concerns about breaking changes / should we populate both or just rename the existing attributes? Just wanted to double check 👍

@maorleger
Copy link
Member

cc @hectorhdzg since appInsights uses our tracer - @hectorhdzg any concerns about renaming these attributes or do we need to keep both for backwards compat?

@lmolkova
Copy link
Member Author

lmolkova commented Mar 21, 2024

We did breaking change on .NET and Java - given that plugins are experimental, we can do it.
Still curious what @hectorhdzg would say :)

@hectorhdzg
Copy link
Member

@maorleger JS OTel is currently working on supporting new semconv, work is being tracked here, currently exporters do not support latest semantic convention, including Azure Monitor one, I will sync with Java/.NET folks but I suppose they have code to support backward compatibly attributes, so maybe it makes sense to hold this one for a few, until exporters have support for it.

@lmolkova
Copy link
Member Author

lmolkova commented Mar 22, 2024

@hectorhdzg
Copy link
Member

@lmolkova Created following issue to track on exporter side, we are waiting for @opentelemetry/semantic-conventions to have latest attributes, we will update when they are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific). For the issues related to the @azure/ope OpenTelemetryInstrumentation
Projects
None yet
Development

No branches or pull requests

3 participants