This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Fix #325 #349
Merged
Fix #325 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use WindowsAzure\Common\Internal\Utilities; | ||
|
|
||
| /** | ||
| * The result of calling copyBlob API/ |
There was a problem hiding this comment.
Typo: Replace trailing slash with trailing dot.
There was a problem hiding this comment.
Yeah I did that already in the next commit. I was revising the pull request before sending it.
| * @return CopyBlobResult | ||
| */ | ||
| public static function create($headers) | ||
| { |
There was a problem hiding this comment.
Why static method but not a constructor?
There was a problem hiding this comment.
That make the code more readable when using this function as a constructor would require passing clean values instead of raw data like $headers
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.