Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-communication-identity] Fixed typing issue for mypy #33965

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[azure-communication-identity] Fixed typing issue for mypy #33965

merged 1 commit into from
Jan 23, 2024

Conversation

AikoBB
Copy link
Member

@AikoBB AikoBB commented Jan 23, 2024

Description

Fixed typing issue of the mypy
#32837

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@AikoBB AikoBB linked an issue Jan 23, 2024 that may be closed by this pull request
azure-communication-identity needs typing updates for mypy version 1.6.1 #32837
Closed
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 23, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@AikoBB AikoBB linked an issue Jan 23, 2024 that may be closed by this pull request
azure-communication-sms needs typing updates for mypy version 1.10.1 #32842
Open
@AikoBB AikoBB removed a link to an issue Jan 23, 2024
azure-communication-sms needs typing updates for mypy version 1.10.1 #32842
Open
@AikoBB AikoBB force-pushed the aigerimb/azure-communication-identity/mypy-check-fix branch from cbe0670 to 154578a Compare January 23, 2024 13:11
@AikoBB AikoBB merged commit a799907 into Azure:main Jan 23, 2024
13 of 19 checks passed
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-python that referenced this pull request Feb 16, 2024
@AikoBB @sofiar-msft
fixed mypy issues for acs identity sdk (Azure#33965)
1279d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximrytych-ms maximrytych-ms maximrytych-ms approved these changes

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft

@besh2014 besh2014 Awaiting requested review from besh2014

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft

Assignees
No one assigned
Labels
Communication - Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure-communication-identity needs typing updates for mypy version 1.6.1
3 participants
@AikoBB @azure-sdk @maximrytych-ms