ai client support for tracing operations, inference instrumentation as… #37820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… part of inference library
github-actions
bot
added
AI
AI Model Inference
dargilco
reviewed
Oct 9, 2024
| # ) | ||
|
|
||
| # Get an authenticated OpenAI client for your default Azure OpenAI connection: | ||
| client = ai_client.inference.get_azure_openai_client() |
There was a problem hiding this comment.
This should be .get_chat_completions_client(), since it looks like you are expecting azure.ai.infernce ChatCompletionsClient to be returned, not AzureOpenAI client from openai package.
jhakulin
reviewed
Oct 9, 2024
|
|
||
| # If you do not specify semantic conventions version, then the default version supported by the current | ||
| # Inference SDK will be returned. | ||
| instrumentor = ai_client.tracing.create_inference_instrumentor() |
There was a problem hiding this comment.
I wonder if this is anti-pattern on OTEL instrumentation? @lmolkova
ai_client.tracing.instrument_inference()
do something
ai_client.tracing.uninstrument_inference()
jhakulin
approved these changes
Oct 10, 2024
M-Hietala
requested review from
luigiw,
needuv,
achauhan-scc,
kingernupur,
paulshealy1 and
singankit
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… part of inference library
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines