Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Took out streaming from create_run, create_and_process_run, and submit_tool_outputs_to_run and declare separate functions for streaming #37851

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

howieleung
Copy link

…t_tool_outputs_to_run and declare separate functions for streaming

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

…t_tool_outputs_to_run and declare separate functions for streaming
Copy link
Member

@jhakulin jhakulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super fast work here. I added some comments.

@howieleung howieleung merged commit 1eea304 into dargilco/azure-ai-client Oct 11, 2024
3 of 4 checks passed
@howieleung howieleung deleted the howie/split-threadrun-and-stream branch October 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants