Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous updates #37852

Merged
merged 12 commits into from
Oct 11, 2024
Merged

Miscellaneous updates #37852

merged 12 commits into from
Oct 11, 2024

Conversation

dargilco
Copy link
Member

@dargilco dargilco commented Oct 11, 2024 •
edited
Loading

  • Re-emit SDK from new TypeSpec, that
    • renamed "workspace_name" to "project_name"
    • made "AuthenticationType" and "EndpointType" classes public
    • Added some missing ref-doc comments to models
  • Per comment in SDK review meeting today, rename input argument "connection" to "conn_str" in the AzureAIClient constructor. I do see that a lot of Azure SDKs use "conn_str".
  • Remove showing the detailed AzureAIClient constructor in sample code.
  • Assume connection string DOES NOT include the "https://" at the beginning.
  • Switch to using the 'with' pattern for sync samples in .endpoints and .inference
  • Use latest GA api_version for Azure OpenAI client library

@github-actions github-actions bot added the AI label Oct 11, 2024
howieleung
howieleung approved these changes Oct 11, 2024
View reviewed changes
Copy link

@howieleung howieleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it will break many of the other agents samples. But I still approve and I will fix those.

@dargilco dargilco merged commit e204002 into dargilco/azure-ai-client Oct 11, 2024
3 of 4 checks passed
@dargilco dargilco deleted the dargilco/azure-ai-client-pr-10-10 branch October 11, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhakulin jhakulin jhakulin approved these changes

@howieleung howieleung howieleung approved these changes

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@achauhan-scc achauhan-scc Awaiting requested review from achauhan-scc achauhan-scc is a code owner

@kingernupur kingernupur Awaiting requested review from kingernupur kingernupur is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

Assignees
No one assigned
Labels
AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dargilco @jhakulin @howieleung