Support for UPN #32
Merged
Support for UPN #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @paulmey @Catbuttes if you get a chance, could you guys please review this PR? |
|
LGTM |
codebien
added a commit
to grafana/k6
that referenced
this pull request
Jul 5, 2022
It brings the UPN support Azure/go-ntlmssp#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for UPN
If the user name contains upn (user@domain.com) or SAM (domain\sam), NOT prepending the domain name or netbios name while sending the response to challenge. (TYPE 3 token).
If the username doesn't fall under category either UPN or SAM, prepending the domain name coming from (type 2 token) in the username while sending the response to server challenge.
upn (user@domain.com) -- \user@domain.com
SAM (domain\user) -- domain\user
username (user) -- DOMAIN\user.