Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling warnings and adding OIDC promotion message release PR #222

Merged
merged 9 commits into from
May 2, 2022
Merged

Handling warnings and adding OIDC promotion message release PR #222

merged 9 commits into from
May 2, 2022

Conversation

BALAGA-GAYATRI
Copy link
Contributor

Resolves #216

  • Warnings will not be thrown as errors
  • Adding an additional OIDC promotion message when a user opts for Non-OIDC login

Screenshot 2022-05-02 at 12 46 27 PM

tauhid621
tauhid621 approved these changes May 2, 2022
View reviewed changes
Copy link

@tauhid621 tauhid621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Left NIT comments.

src/main.ts Outdated Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
@BALAGA-GAYATRI BALAGA-GAYATRI merged commit ec3c145 into releases/v1 May 2, 2022
@BALAGA-GAYATRI BALAGA-GAYATRI deleted the release-patch-1 branch June 15, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tauhid621 tauhid621 tauhid621 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BALAGA-GAYATRI @tauhid621