Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove open/close scripts #228

Merged
merged 24 commits into from
Feb 8, 2023
Merged

Remove open/close scripts #228

merged 24 commits into from
Feb 8, 2023

Conversation

KSchlobohm
Copy link
Contributor

@KSchlobohm KSchlobohm commented Feb 3, 2023

Change impacts

  • network access for Key Vault
  • network access for App Configuration Service
  • can now run workflow without tearing down resources
  • added new parameter to give the user a Role Assignment
  • consolidated app config service keys to one location

Resolves issues

@KSchlobohm KSchlobohm marked this pull request as ready for review February 4, 2023 00:44
Copy link
Contributor

@kwkraus kwkraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KSchlobohm Tested this PR twice, and both times I ran into this issue

image

@KSchlobohm KSchlobohm self-assigned this Feb 7, 2023
@KSchlobohm
Copy link
Contributor Author

Good catch @kwkraus - this was a bug in the PR change to the output var from azureRedisCache.bicep

This has been fixed

Here's how I found it
image

should have been:
image
I used the Azure Portal after running azd provision to create a 2nd key vault reference value and then did a compare between the two to see the difference which is the URI string that changed

@KSchlobohm KSchlobohm merged commit afbbd33 into main Feb 8, 2023
@KSchlobohm KSchlobohm deleted the kschlobohm/open-close branch February 8, 2023 19:39
@KSchlobohm
Copy link
Contributor Author

also resolved #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants