ci: fix shellcheck file paths (#786)

* ci: fix shellcheck file paths Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * chore: fix shellcheck failures Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Azure · Feb 1, 2022 · 4f79862 · 4f79862
1 parent c407a87
commit 4f79862
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -81,7 +81,7 @@ lint: $(TOOLS_DIR)/golangci-lint $(TOOLS_DIR)/misspell
 
 .PHONY: shellcheck
 shellcheck: $(SHELLCHECK)
-	$(SHELLCHECK) */*.sh
+	find . -name '*.sh' | xargs $(SHELLCHECK)
 
 .PHONY: unit-test
 unit-test:

diff --git a/examples/kind/kind-demo.sh b/examples/kind/kind-demo.sh
@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 CLIENT_ID=$1
 CLIENT_SECRET=$2
 
@@ -9,7 +11,8 @@ helm repo add csi-secrets-store-provider-azure https://azure.github.io/secrets-s
 helm install csi-secrets-store-provider-azure/csi-secrets-store-provider-azure --generate-name
 
 # create secret in k8
-kubectl create secret generic secrets-store-creds --from-literal clientid=$CLIENT_ID --from-literal clientsecret=$CLIENT_SECRET
+kubectl create secret generic secrets-store-creds --from-literal clientid="$CLIENT_ID" --from-literal clientsecret="$CLIENT_SECRET"
+
 # label the secret
 kubectl label secret secrets-store-creds secrets-store.csi.k8s.io/used=true