chore: update manifests for release 0.0.8 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
manifests-0.0.8
branch
2 times, most recently
from
5fce773
to
fc96585
Compare
aramase
force-pushed
the
manifests-0.0.8
branch
3 times, most recently
from
04271f9
to
b6b7bfc
Compare
aramase
force-pushed
the
manifests-0.0.8
branch
from
b6b7bfc
to
4ede6cd
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ritazh
reviewed
Aug 19, 2020
|
|
||
| @test "install azure provider with e2e image" { | ||
| yq w -d 1 ${PROVIDER_YAML} "spec.template.spec.containers[0].image" "${PROVIDER_TEST_IMAGE}:${IMAGE_TAG}" \ |
There was a problem hiding this comment.
The driver and provider are installed using the helm charts, so we no longer need to install using kubectl apply -f
There was a problem hiding this comment.
Issue to track testing with deployment yamls - #196
There was a problem hiding this comment.
This issue is being tracked here to unblock this PR.
ritazh
reviewed
Aug 19, 2020
| --set image.repository=${PROVIDER_TEST_IMAGE} \ | ||
| --set image.tag=${IMAGE_TAG} \ | ||
| --set image.pullPolicy="IfNotPresent" \ | ||
| --dependency-update |
ritazh
reviewed
Aug 19, 2020
| @@ -41,7 +41,7 @@ helm install stable/nginx-ingress --generate-name \ | |||
| - Set secret type to `kubernetes.io/tls` | |||
|
|
|||
| ```bash | |||
| $ cat <<EOF | kubectl apply -f - | |||
| $ cat <<EOF | kubectl apply -n ingress-test -f - | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #121
Fixes #195
Fixes #120
Fixes #37
Special notes for your reviewer: