Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update driver to v0.0.16 and add tests for rotation with diff auth modes #265

Merged
merged 2 commits into from
Oct 10, 2020
Merged

update driver to v0.0.16 and add tests for rotation with diff auth modes #265

merged 2 commits into from
Oct 10, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 9, 2020 •
edited
Loading

Reason for Change:

  • Update driver to v0.0.16
  • Add e2e tests for rotation with service principal, managed identity and pod identity

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Special Notes for Reviewers:

@aramase aramase force-pushed the bump-v0.0.16 branch 2 times, most recently from 7f7c312 to 321842e Compare October 9, 2020 18:50
@aramase
Copy link
Member Author

aramase commented Oct 9, 2020

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase mentioned this pull request Oct 9, 2020
Merged
@aramase aramase changed the title test: add tests for rotation with diff auth modes update driver to v0.0.16 and add tests for rotation with diff auth modes Oct 10, 2020
ritazh
ritazh approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 7fbc0cd into Azure:master Oct 10, 2020
@aramase aramase deleted the bump-v0.0.16 branch October 10, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramase @ritazh