-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uses provisioningState to verify ext install #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 62.74% 62.74%
=======================================
Files 7 7
Lines 765 765
=======================================
Hits 480 480
Misses 252 252
Partials 33 33 |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test
aramase
reviewed
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit, otherwise lgtm!
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
…rets-store-csi-driver-provider-azure into fix-arc-nightly-test
aramase
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com
Reason for Change:
Fixes nightly run for Arc extension
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: