Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uses provisioningState to verify ext install #694

Merged
merged 13 commits into from
Oct 27, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Oct 26, 2021

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

Reason for Change:

Fixes nightly run for Arc extension

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #694 (c753288) into master (e34837b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   62.74%   62.74%           
=======================================
  Files           7        7           
  Lines         765      765           
=======================================
  Hits          480      480           
  Misses        252      252           
  Partials       33       33           

@nilekhc nilekhc requested a review from aramase October 26, 2021 20:06
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit, otherwise lgtm!

.pipelines/templates/e2e-test-kind-arc.yaml Outdated Show resolved Hide resolved
@nilekhc nilekhc requested a review from aramase October 26, 2021 23:43
@nilekhc nilekhc merged commit a207c91 into Azure:master Oct 27, 2021
@nilekhc nilekhc deleted the fix-arc-nightly-test branch October 27, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants