feat: add configuration for file permission #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implements outbound proxy support for arc extension Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
- Coverage 62.09% 62.02% -0.08%
==========================================
Files 7 7
Lines 765 782 +17
==========================================
+ Hits 475 485 +10
- Misses 257 263 +6
- Partials 33 34 +1 |
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
reviewed
Jan 13, 2022
There was a problem hiding this comment.
Added few comments! To summarize,
- If no file permission is provided, we should default to the permission provided by the driver (same as today). This can be done when the objects to retrieve are unmarshalled.
- The validation for file permission should happen before actual call to keyvault to avoid making keyvault API calls when final result is an error.
Let's move the validation to a function so we can also unit test it
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
aramase
reviewed
Jan 18, 2022
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I have added e2e tests for kind cluster. |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
added. |
aramase
reviewed
Jan 19, 2022
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
aramase
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds support for file permission for secrets being written to the pod.
Requirements
Issue Fixed:
fixes #712
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: