Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use secret file for object versions #761

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 19, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #761 (8203339) into master (c06bc12) will decrease coverage by 0.36%.
The diff coverage is 42.42%.

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   62.02%   61.65%   -0.37%     
==========================================
  Files           7        7              
  Lines         782      785       +3     
==========================================
- Hits          485      484       -1     
- Misses        263      267       +4     
  Partials       34       34              

@aramase
Copy link
Member Author

aramase commented Jan 19, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review January 19, 2022 21:26
@aramase aramase requested a review from nilekhc January 20, 2022 17:27
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit. Otherwise looks good.

pkg/provider/provider.go Outdated Show resolved Hide resolved
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from nilekhc January 20, 2022 17:53
@aramase aramase merged commit 9492015 into Azure:master Jan 20, 2022
@aramase aramase deleted the refactor-version branch January 20, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants